Conversion of the Heretics!

adodb-mysql.inc.php, line 131.

qstr is “if magic_quotes disabled, use mysql_real_escape_string”.

Reading the code can save you the need to reinvent the wheel.

Both ADOdb and ADOdb Lite will use mysql_real_escape_string is the PHP version is 4.3.0 or higher. Otherwise it will use a software escape routine.

And I completely forgot about the pg_escape_string function in PHP. I will add that to the qstr function in the postgres drivers tonight for the next release.

Wow. Am I effecting actual change? lol. Should I start listing all the PHP native (well, lib based) functions for other databases?

The pg_escape_string function will be a nice addition, I use Postgres quite a lot more than MySQL. Thanks to PJ… Also noting that there’s a pg_escape_bytea distinct from string escaping…

I should have read, then posted – got a little lazy at 12am…

After checking, pg_escape_string appears commented OUT of the ADOdb code… Its an old version, could have changed since.

Heh heh, when some things should be there are a better way to do something is pointed out I am more than happy to make the change.

And I have no idea why that entire code block is commented out in the postgres driver in ADOdb. Unless he had problems in the past.

And the pg_escape_bytea will be used when I add a Blog/Clob module to the database library. That will actually be fairly easy to do.

Just seems odd to be commented out… Under Postgres then, using qstr is not escaping with a db specific native function. Seems a little suspect…